Skip to content

refactor(well-show): unify floating-label info cards#230

Closed
jirhiker wants to merge 5 commits intostagingfrom
core-well-information
Closed

refactor(well-show): unify floating-label info cards#230
jirhiker wants to merge 5 commits intostagingfrom
core-well-information

Conversation

@jirhiker
Copy link
Copy Markdown
Member

@jirhiker jirhiker commented Mar 30, 2026

Why

This PR addresses the following problem / context:

  • Core well detail cards were using a mix of inline label/value layouts that made the well show page feel inconsistent and harder to scan.
  • The coordinate rows in Core Well Information exposed copy actions that were not needed for this workflow.
  • Recent water level observations included a low-value Release Status column that added noise to the table.

How

Implementation summary - the following was changed / added / removed:

  • Refactored Core Well Information to render its rows as floating-label field shells for a cleaner, more structured presentation.
  • Applied the same floating-label field treatment to Construction Info, Physical Properties, and Geology Information so those sections share a consistent visual pattern.
  • Preserved multiline display behavior where needed, such as coordinate notes.
  • Removed the copy action from the latitude/longitude and easting/northing rows in Core Well Information.
  • Removed the Release Status column from Recent Water Level Observations.
  • Included minor formatting cleanup in the recent observations card while touching that component.

Notes

Any special considerations, workarounds, or follow-up work to note?

  • This is a UI-only change; no backend behavior or data contracts were modified.
  • Visual verification on the well show page is the main validation needed for this PR.

@jirhiker jirhiker changed the title refactor(well-info): Simplify layout and enhance FieldRow component for better readability refactor(well-show): unify floating-label info cards Mar 30, 2026
@jirhiker jirhiker requested a review from jeremyzilar March 30, 2026 21:12
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e0240d4c1e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@github-actions
Copy link
Copy Markdown

Preview Deployment

Preview URL: $PREVIEW_URL

Note: This preview uses the staging API endpoints and has auth disabled for testing.

@github-actions
Copy link
Copy Markdown

Preview Deployment

Preview URL: $PREVIEW_URL

Note: This preview uses the staging API endpoints and has auth disabled for testing.

1 similar comment
@github-actions
Copy link
Copy Markdown

Preview Deployment

Preview URL: $PREVIEW_URL

Note: This preview uses the staging API endpoints and has auth disabled for testing.

@github-actions
Copy link
Copy Markdown

Preview Deployment

Preview URL: $PREVIEW_URL

Note: This preview uses the staging API endpoints and has auth disabled for testing.

# Conflicts:
#	src/components/WellShow/Equipment.tsx
@jirhiker
Copy link
Copy Markdown
Member Author

Screenshot 2026-03-31 at 11 05 52 AM

@github-actions
Copy link
Copy Markdown

Preview Deployment

Preview URL: $PREVIEW_URL

Note: This preview uses the staging API endpoints and has auth disabled for testing.

@jeremyzilar
Copy link
Copy Markdown
Contributor

@jirhiker I would like to close this and handle the design of this differently across the board, rather than just fixing this PR. I am happy to start a new PR for it and run it by you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants